Diag fig fix #73
Merged
Diag fig fix #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 90.49% 94.48% +3.99%
==========================================
Files 15 14 -1
Lines 1136 1088 -48
==========================================
Hits 1028 1028
+ Misses 108 60 -48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Great, thanks! Odd that the tests are failing locally but not on the GitHub Actions, I wonder if there's something in a newer version of xarray or numpy that's changing tolerance behavior... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing diag_fig to accept an xarray data array (in addition to dataset). The documentation says this is possible but it is not due to the direct call to create_raster_polygons which skips the wrapper where data arrays are converted to datasets. I've copied the dataset conversion lines to diag_fig from the pixel_overlaps wrapper.
I ran the tests and found 4 fails but they are unrelated to my edits as the fails were present beforehand. This PR includes a fix for two of the fails. They were related to trying to delete the test.nc temporary file while it is open in test_to_netcdf.
The other two fails are related to precision/tolerance, which I didn't look into. (platform win32 -- Python 3.12.4, pytest-8.2.2, pluggy-1.5.0)