Fixing wraparound issue #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identified several sources of errors: - in `create_raster_polygons`, since shapely Polygons don't have .crs information, following GeoJSON conventions pixels crossing the antimeridian now are split into a MultiPolygon with separate Polygons on either side of the antimeridian. - _however_, `xa.aux.get_bnds()` has a bug in it in which incorrect bounds are created, this will be the next step to look at There are a bunch of random fixes as well, including: - switching `.dims()` to `.sizes()` to silence the depreciation warning
Fixes #51, which is related to pixels incorrectly splitting at the antimeridian. This required two fixes: 1) `create_raster_polygons()` updated to GeoJSON standards of splitting pixels that cross the antimeridian *at* the antimerdiain, forming a MultiPolygon 2) `get_bnds()` updated to correctly set bounds of grids that cross the antimeridian This commit also adds or updates many tests to make sure this process works correctly, including `get_bnds()` tests checking - partial grids - grids crossing the antimeridian - grids with individual grid cells on both sides of the antimeridian Further, adds a `NoOverlapError` raised when the polygons and input rasters don't overlap at all.
Workaround for issues stemming from pydata/xarray#8743 By replicating the source_grid dataset from scratch / from .values before exporting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes
Closes #51 by:
create_raster_polygons()such that it splits antimeridian-crossing grid cells into two components of a MultiPolygon, to be in line with GeoJSON conventions (inspired by the solution in https://github.com/gadomski/antimeridian).shapelydoes not see any CRS information and therefore treats -180:180 as a number line; splitting Polygons at the antimeridian is a workaround for this.get_bnds()to correctly produce lat/lon bounds for pixels close to the antimeridian, with a handful of new tests for edge casesMinor changes
NoOverlapErrorfor when polygons do not overlap with any grid cells in the samplexa.fix_ds()now only sorts values when a check sees them to be unsorted - this is to avoid loading into memory when not needed (sincexa.fix_ds()is used outside ofxaggas well)ds.dims.keys()tods.sizes()references to avoid warnings