Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes isValidClosureName to handle generic types correctly. #845

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Fixes isValidClosureName to handle generic types correctly. #845

merged 3 commits into from
Jul 13, 2020

Conversation

asifmujteba
Copy link
Contributor

Fixes #844

krzysztofzablocki
krzysztofzablocki approved these changes Jul 10, 2020
View reviewed changes
Copy link
Owner

@krzysztofzablocki krzysztofzablocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thank you :)

@krzysztofzablocki krzysztofzablocki merged commit 6f2c00f into krzysztofzablocki:master Jul 13, 2020
@jpsim jpsim mentioned this pull request Sep 10, 2020
Closed
@jpsim
Copy link
Contributor

jpsim commented Sep 10, 2020

This change introduced a crash in my use of Sourcery: #856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyapuchka ilyapuchka ilyapuchka left review comments

@krzysztofzablocki krzysztofzablocki krzysztofzablocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String.isValidClosureName() returns false positive for types which have closure as a generic type
4 participants
@asifmujteba @jpsim @krzysztofzablocki @ilyapuchka