url: fix error message of url.format

PR-URL: nodejs#11162 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
krydos · Feb 25, 2017 · f39c7d9 · f39c7d9
1 parent 431c803
commit f39c7d9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 12 deletions.
diff --git a/lib/url.js b/lib/url.js
@@ -547,7 +547,7 @@ function urlFormat(obj, options) {
     obj = urlParse(obj);
   } else if (typeof obj !== 'object' || obj === null) {
     throw new TypeError('Parameter "urlObj" must be an object, not ' +
-                        obj === null ? 'null' : typeof obj);
+                        (obj === null ? 'null' : typeof obj));
   } else if (!(obj instanceof Url)) {
     var format = obj[internalUrl.formatSymbol];
     return format ?

diff --git a/test/parallel/test-url-format-invalid-input.js b/test/parallel/test-url-format-invalid-input.js
@@ -3,17 +3,20 @@ require('../common');
 const assert = require('assert');
 const url = require('url');
 
-// https://github.com/nodejs/node/pull/1036
-const throws = [
-  undefined,
-  null,
-  true,
-  false,
-  0,
-  function() {}
-];
-for (let i = 0; i < throws.length; i++) {
-  assert.throws(function() { url.format(throws[i]); }, TypeError);
+const throwsObjsAndReportTypes = new Map([
+  [undefined, 'undefined'],
+  [null, 'null'],
+  [true, 'boolean'],
+  [false, 'boolean'],
+  [0, 'number'],
+  [function() {}, 'function'],
+  [Symbol('foo'), 'symbol']
+]);
+
+for (const [obj, type] of throwsObjsAndReportTypes) {
+  const error = new RegExp('^TypeError: Parameter "urlObj" must be an object' +
+                           `, not ${type}$`);
+  assert.throws(function() { url.format(obj); }, error);
 }
 assert.strictEqual(url.format(''), '');
 assert.strictEqual(url.format({}), '');