Retry INVM server startup.#94
Merged
Merged
Conversation
robobario
reviewed
Apr 27, 2023
k-wall
reviewed
Apr 27, 2023
k-wall
approved these changes
Apr 27, 2023
k-wall
left a comment
k-wall
left a comment
Member
There was a problem hiding this comment.
Change looks good. I reviewed the kafka.server.KafkaRaftServer#startup and kafka.server.KafkaServer#startup to ensure they have idempotency. In the failure, they both take steps to call shutdown down methods which appear to reverse any parts of startup that succeeded.
Startup is cheap, and is usually related to transient port binding issues. Signed-off-by: Sam Barker <sbarker@redhat.com>
Signed-off-by: Sam Barker <sbarker@redhat.com>
Signed-off-by: Sam Barker <sbarker@redhat.com>
SamBarker
force-pushed
the
retry_invm_startup
branch
from
April 27, 2023 09:32
25d4c64 to
e0abbd2
Compare
Member
|
Great workaround for this kind of failure! LGTM. Thanks @SamBarker |
franvila
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startup is cheap, and is usually related to transient port binding issues.
I was hoping to say we could drop this once we get to Kafka 3.6.0 but then I saw apache/kafka#13572 (comment) so there is some debate if it will land and when...