Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIBS-243 Add LoggerInterface and LogLocatorLogger #100

Merged
merged 2 commits into from
Apr 28, 2023
Merged

LIBS-243 Add LoggerInterface and LogLocatorLogger #100

merged 2 commits into from
Apr 28, 2023

Conversation

etremblay
Copy link
Contributor

@etremblay etremblay commented Apr 27, 2023 •
edited
Loading

https://jira.equisoft.com/browse/LIBS-243

  • Lorsqu'un logger est injecté par le DI, il n'utilise plus le LogLocator. Il reste alors collé avec un logger qui log seulement des E_NOTICE php
  • Les fonctions d'ajout de contexte et exception() sont tannante à utiliser car elles ne sont pas dans l'interface Psr

CRM https://github.com/kronostechnologies/kronos-crm/pull/9776/

@etremblay etremblay requested review from a team April 27, 2023 19:06
GTony
GTony approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@GTony GTony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@etremblay etremblay merged commit 5426ee1 into master Apr 28, 2023
@etremblay etremblay deleted the dev/LIBS-243-logger-interface-and-locator branch April 28, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GTony GTony GTony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etremblay @GTony