Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TextInput): ajout adornment (DS-1140) #949

Merged
merged 9 commits into from
Sep 27, 2024
Merged

feat(TextInput): ajout adornment (DS-1140) #949

merged 9 commits into from
Sep 27, 2024

Conversation

WilliamsTardif
Copy link
Contributor

JIRA: https://equisoft.atlassian.net/browse/DS-1140

Description des changements

  • Possibilité d'ajouter un adornment.
    L'adornement peut être un Icon ou du text.
  • Possible d'ajouter l'adornment au début ou la fin du TextInput.
  • Lorsqu'on click sur l'adornement le TextInput est focus.

@WilliamsTardif WilliamsTardif requested a review from a team as a code owner July 22, 2024 16:07
@github-actions GitHub Actions
Copy link

Storybook for this build: https://ds.equisoft.io/pr-949/

@github-actions GitHub Actions
Copy link

Webapp for this build: https://ds.equisoft.io/pr-949/webapp/

LarryMatte
LarryMatte requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@LarryMatte LarryMatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quelques petites modifications ici et là.

packages/react/src/components/text-input/text-input.tsx Outdated Show resolved Hide resolved
packages/storybook/stories/text-input.stories.tsx Outdated Show resolved Hide resolved
packages/react/src/components/text-input/text-input.tsx Outdated Show resolved Hide resolved
packages/react/src/components/text-input/text-input.tsx Outdated Show resolved Hide resolved
meriouma
meriouma reviewed Aug 16, 2024
View reviewed changes
packages/react/src/components/money-input/money-input.test.tsx.snap
@@ -100,15 +123,19 @@ exports[`CurrencyInput Component matches snapshot (en-CA) 1`] = `
class="c1"
data-testid="field-container"
>
<input
<div
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je sais pas si c'est voulu, mais cette div là dans le MoneyInput affecte la longueur du champ. C'est peut-être mieux de même pour pouvoir ajuster plus facilement la longueur du champ par contre.

Copy link
Contributor Author

@WilliamsTardif WilliamsTardif Sep 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne crois pas que sa soit voulu 😅
Mais bien heureux de l'avoir améliorer en quelque sorte 👌

packages/react/src/components/text-input/text-input.tsx Outdated Show resolved Hide resolved
packages/react/src/components/text-input/text-input.tsx Outdated Show resolved Hide resolved
packages/react/src/components/text-input/text-input.tsx Outdated Show resolved Hide resolved
packages/react/src/components/text-input/text-input.tsx Outdated Show resolved Hide resolved
packages/react/src/components/text-input/text-input.tsx Outdated Show resolved Hide resolved
packages/react/src/components/text-input/text-input.tsx Outdated Show resolved Hide resolved
packages/react/src/components/text-input/text-input.tsx Outdated Show resolved Hide resolved
packages/react/src/themes/tokens/component/text-input-tokens.ts Outdated Show resolved Hide resolved
packages/storybook/stories/text-input.mdx
@@ -11,25 +11,31 @@ import * as TextInputStories from './text-input.stories';
4. [Properties](#properties)

## Definition
Text input allows users to enter a single line of text into a form.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression que ton .editorconfig est pas bon. Les trailing whitespaces devraient pas être enlevées par ton éditeur.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourtant en vérifiant trim_trailing_whitespace est à false. 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi on override ça pour les mdx? Quels sont les cas légitimes pour laisser des trailing whitespaces?

Copy link
Contributor

@meriouma meriouma Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En markdown normalement 2 espaces = 1 saut de ligne. Alors si tu veux un vrai saut de ligne, ça arrive que la ligne finisse par

Ma première ligne.<espace> 
Ma deuxième ligne.

Par contre je sais plus comment c'est interprété par storybook pour le MDX. Par le passé c'était nécessaire pour garder le saut de ligne il me semble.

maboilard
maboilard previously approved these changes Aug 26, 2024
View reviewed changes
LarryMatte
LarryMatte requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@LarryMatte LarryMatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petit commentaire en ce qui me concerne, pour le reste, je laisse Max, P-Y et Savut faire le tour.

packages/react/src/components/text-input/text-input.tsx Show resolved Hide resolved
pylafleur
pylafleur previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@pylafleur pylafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LarryMatte
LarryMatte previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@LarryMatte LarryMatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça semble good pour moi. Je fais confiance aux autres pour le reste.
Good job!

maboilard
maboilard previously approved these changes Sep 23, 2024
View reviewed changes
maboilard
maboilard approved these changes Sep 25, 2024
View reviewed changes
Copy link

@maboilard maboilard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pour moi!

@WilliamsTardif WilliamsTardif merged commit aea2a85 into master Sep 27, 2024
22 checks passed
@WilliamsTardif WilliamsTardif deleted the dev/DS-1140 branch September 27, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maboilard maboilard maboilard approved these changes

@savutsang savutsang Awaiting requested review from savutsang

@hebernardEquisoft hebernardEquisoft Awaiting requested review from hebernardEquisoft

@meriouma meriouma Awaiting requested review from meriouma

@LarryMatte LarryMatte Awaiting requested review from LarryMatte

@pylafleur pylafleur Awaiting requested review from pylafleur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@WilliamsTardif @meriouma @pylafleur @savutsang @LarryMatte @maboilard @hebernardEquisoft