Skip to content

Commit

Permalink
fix(Pagination): change span for div (#965)
Browse files Browse the repository at this point in the history
  • Loading branch information
LarryMatte authored Aug 7, 2024
1 parent 0439711 commit 2eb2827
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ exports[`Pagination Matches the desktop snapshot 1`] = `
aria-labelledby="uuid1"
class="c1"
>
<span
<div
aria-live="off"
role="status"
>
Expand All @@ -89,7 +89,7 @@ exports[`Pagination Matches the desktop snapshot 1`] = `
0–0 of 0 results
</span>
</h3>
</span>
</div>
<ol
class="c5"
/>
Expand Down Expand Up @@ -165,7 +165,7 @@ exports[`Pagination Matches the desktop snapshot with multiples digits page numb
aria-labelledby="uuid1"
class="c1"
>
<span
<div
aria-live="off"
role="status"
>
Expand All @@ -186,7 +186,7 @@ exports[`Pagination Matches the desktop snapshot with multiples digits page numb
0–0 of 0 results
</span>
</h3>
</span>
</div>
<ol
class="c5"
/>
Expand Down Expand Up @@ -262,7 +262,7 @@ exports[`Pagination Matches the mobile snapshot 1`] = `
aria-labelledby="uuid1"
class="c1"
>
<span
<div
aria-live="off"
role="status"
>
Expand All @@ -283,7 +283,7 @@ exports[`Pagination Matches the mobile snapshot 1`] = `
0–0 of 0 results
</span>
</h3>
</span>
</div>
<ol
class="c5"
/>
Expand Down Expand Up @@ -359,7 +359,7 @@ exports[`Pagination Matches the mobile snapshot with multiples digits page numbe
aria-labelledby="uuid1"
class="c1"
>
<span
<div
aria-live="off"
role="status"
>
Expand All @@ -380,7 +380,7 @@ exports[`Pagination Matches the mobile snapshot with multiples digits page numbe
0–0 of 0 results
</span>
</h3>
</span>
</div>
<ol
class="c5"
/>
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/components/pagination/pagination.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export const Pagination: VoidFunctionComponent<PaginationProps> = ({
return (
<Container className={className} isMobile={isMobile}>
<Navigation aria-labelledby={ariaLabelledby}>
<span aria-live='off' role='status'>
<div aria-live='off' role='status'>
<CurrentPageLabelHeading id={headingId} data-testid="currentPageLabelHeading">
<ResultsLabel isMobile={isMobile} data-testid="resultsLabel">
<ScreenReaderOnlyText label={`${t('pagination')} - `} />
Expand All @@ -215,7 +215,7 @@ export const Pagination: VoidFunctionComponent<PaginationProps> = ({
})}
</ResultsLabel>
</CurrentPageLabelHeading>
</span>
</div>
{forwardBackwardNavActive && (
<NavButton
data-testid="previousPageButton"
Expand Down

0 comments on commit 2eb2827

Please sign in to comment.