pkg simpleschema: adds SimpleSchema enum support by DhairyaMajmudar · Pull Request #424 · kubernetes-sigs/kro

DhairyaMajmudar · 2025-03-19T13:44:24Z

Description

Adds Enum Support to pkg simpleschema
Adds relevant tests cases for the same

fixes #304

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

a-hilaly

Thanks @DhairyaMajmudar ! i have two nits below:

pkg/simpleschema/markers.go

pkg/simpleschema/transform.go

pkg/simpleschema/transform_test.go

Co-authored-by: Amine <hilalyamine@gmail.com>

Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

DhairyaMajmudar · 2025-03-20T09:35:39Z

Thank you @a-hilaly @matthchr for the review, updated my PR following the same.

pkg/simpleschema/transform.go

pkg/simpleschema/transform_test.go

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

pkg/simpleschema/transform.go

pkg/simpleschema/atomic.go

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

pkg/simpleschema/transform.go

Co-authored-by: Amine <hilalyamine@gmail.com>

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

pkg/simpleschema/transform.go

pkg/simpleschema/transform_test.go

pkg/simpleschema/transform.go

Co-authored-by: Amine <hilalyamine@gmail.com>

pkg/simpleschema/transform_test.go

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

a-hilaly

Thanks a lot @DhairyaMajmudar !

* pkg simpleschema: adds SimpleSchema enum support Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in> Co-authored-by: Amine <hilalyamine@gmail.com> Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>

pkg simpleschema: adds SimpleSchema enum support

8f98432

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

a-hilaly reviewed Mar 19, 2025

View reviewed changes

pkg/simpleschema/markers.go Outdated Show resolved Hide resolved

pkg/simpleschema/transform.go Outdated Show resolved Hide resolved

matthchr reviewed Mar 19, 2025

View reviewed changes

DhairyaMajmudar and others added 7 commits March 20, 2025 10:50

Update pkg/simpleschema/markers.go

c9b4019

Co-authored-by: Amine <hilalyamine@gmail.com>

Update pkg/simpleschema/transform.go

cf40d1d

Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>

enumJsonValues -> enumJSONValues

f4dff31

fix: removed boolean enum

ee57ea0

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

fea: adding better error handling

5db9e88

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

tests: adding tests cases for number type

74fd90c

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

tests: added negative test cases to check invalid enum

763c707

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

DhairyaMajmudar requested review from a-hilaly and matthchr March 20, 2025 09:35

matthchr reviewed Mar 20, 2025

View reviewed changes

pkg/simpleschema/transform.go Outdated Show resolved Hide resolved

pkg/simpleschema/transform_test.go Show resolved Hide resolved

DhairyaMajmudar added 2 commits March 20, 2025 22:18

test: added test to check empty enum

821e343

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

test: seperating empty test case

987c78f

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

a-hilaly reviewed Mar 21, 2025

View reviewed changes

pkg/simpleschema/transform.go Show resolved Hide resolved

a-hilaly reviewed Mar 21, 2025

View reviewed changes

pkg/simpleschema/atomic.go Outdated Show resolved Hide resolved

fixes: removed number case

58d2f70

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

a-hilaly reviewed Mar 22, 2025

View reviewed changes

pkg/simpleschema/transform.go Outdated Show resolved Hide resolved

pkg/simpleschema/transform.go Outdated Show resolved Hide resolved

pkg/simpleschema/transform.go Outdated Show resolved Hide resolved

DhairyaMajmudar and others added 3 commits March 22, 2025 12:08

Update pkg/simpleschema/transform.go

0202c60

Co-authored-by: Amine <hilalyamine@gmail.com>

fix: skiping empty strings and added a test case

e0bedbe

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

fix: removing extra changes

affdf65

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

a-hilaly mentioned this pull request Mar 22, 2025

feat: add enum support in marker type #337

Closed

a-hilaly reviewed Mar 22, 2025

View reviewed changes

pkg/simpleschema/transform.go Outdated Show resolved Hide resolved

pkg/simpleschema/transform_test.go Outdated Show resolved Hide resolved

pkg/simpleschema/transform_test.go Outdated Show resolved Hide resolved

pkg/simpleschema/transform.go Outdated Show resolved Hide resolved

DhairyaMajmudar and others added 4 commits March 22, 2025 13:28

Update pkg/simpleschema/transform.go

4e9f8b4

Co-authored-by: Amine <hilalyamine@gmail.com>

Update pkg/simpleschema/transform_test.go

088fad1

Co-authored-by: Amine <hilalyamine@gmail.com>

Update pkg/simpleschema/transform_test.go

66846b9

Co-authored-by: Amine <hilalyamine@gmail.com>

Update pkg/simpleschema/transform.go

f0c4621

Co-authored-by: Amine <hilalyamine@gmail.com>

a-hilaly reviewed Mar 22, 2025

View reviewed changes

pkg/simpleschema/transform_test.go Show resolved Hide resolved

tests: adds test cases for invalid enum

8ee044d

Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>

a-hilaly approved these changes Mar 22, 2025

View reviewed changes

a-hilaly requested a review from matthchr March 24, 2025 19:27

matthchr approved these changes Mar 24, 2025

View reviewed changes

a-hilaly merged commit 0b43892 into kubernetes-sigs:main Mar 24, 2025
4 checks passed

DhairyaMajmudar deleted the feat/marker-type-enum branch March 28, 2025 19:54

This was referenced Mar 31, 2025

Enhance error handling for MarkerTypeMinimum & MarkerTypeMaximum #468

Merged

feat: add validation support in marker type #357

Closed

Conversation

DhairyaMajmudar commented Mar 19, 2025 • edited by a-hilaly Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

a-hilaly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DhairyaMajmudar commented Mar 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

a-hilaly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DhairyaMajmudar commented Mar 19, 2025 •

edited by a-hilaly

Loading