Skip to content

fix(deps): pin node-pty to the patched beta so release builds install it - #42

Merged
krl-gr merged 1 commit into
mainfrom
fix/pin-patched-deps
Oct 26, 2026
Merged

krl-gr merged 1 commit into
mainfrom
fix/pin-patched-deps

Conversation

@krl-gr

@krl-gr krl-gr commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Problem

The core-v0.0.37-rc.1 release run failed on all four desktop builds:
[ERR_PNPM_UNUSED_PATCH] The following patches were not used: node-pty@1.2.0-beta.15.
The desktop stage runs pnpm install --prod without our lockfile, so the server's "node-pty": "^1.2.0-beta.15" now resolves to 1.2.0-beta.18 (published 2026-10-22/23), and the patch for beta.15 no longer applies.

Fix

Pin node-pty to exactly 1.2.0-beta.15 in apps/server/package.json and update the lockfile specifier. The other patched runtime deps of the stage (@ff-labs/fff-node, dbus-next) are already exact. Upstream fixed the same drift in pingdotgg/t3code#23798; we take the full version of that with the upstream sync.

Verification

  • pnpm install --frozen-lockfile --lockfile-only passes.
  • A simulated stage install (node-pty: 1.2.0-beta.15 plus the patch, no lockfile) installs beta.15 and applies the patch without errors.

🤖 Generated with Claude Code

The desktop stage installs without the lockfile, so "^1.2.0-beta.15" now
resolves to 1.2.0-beta.18 (published 2026-10-22/23), and pnpm fails with
ERR_PNPM_UNUSED_PATCH for patches/node-pty@1.2.0-beta.15.patch. Pin the
exact version the patch targets. Upstream fixed the same drift in
pingdotgg/t3code#23798 by pinning every patched package.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying upcomputer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 62d4c2d
Status: ✅  Deploy successful!
Preview URL: https://2196546b.upcomputer.pages.dev
Branch Preview URL: https://fix-pin-patched-deps.upcomputer.pages.dev

View logs

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 4.9 KiB −23 B (−0.5%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB −23 B (−1.9%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.8 KiB −41 B (−0.2%) 29.3 KiB ✅
Codex Live turn messages 2 1 −1 (−50.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB +24 B (+0.5%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB +24 B (+2.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB +41 B (+0.2%) 29.3 KiB ✅
Claude Live turn messages 1 2 +1 (+100.0%) 8 ✅

Baseline: 2ef8ea7 · PR result: 62d4c2d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@krl-gr
krl-gr merged commit c6452b2 into main Oct 26, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant