Repository navigation
fix(deps): pin node-pty to the patched beta so release builds install it - #42
Merged
Merged
Conversation
The desktop stage installs without the lockfile, so "^1.2.0-beta.15" now resolves to 1.2.0-beta.18 (published 2026-10-22/23), and pnpm fails with ERR_PNPM_UNUSED_PATCH for patches/node-pty@1.2.0-beta.15.patch. Pin the exact version the patch targets. Upstream fixed the same drift in pingdotgg/t3code#23798 by pinning every patched package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying upcomputer with
|
| Latest commit: |
62d4c2d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2196546b.upcomputer.pages.dev |
| Branch Preview URL: | https://fix-pin-patched-deps.upcomputer.pages.dev |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
core-v0.0.37-rc.1release run failed on all four desktop builds:[ERR_PNPM_UNUSED_PATCH] The following patches were not used: node-pty@1.2.0-beta.15.The desktop stage runs
pnpm install --prodwithout our lockfile, so the server's"node-pty": "^1.2.0-beta.15"now resolves to 1.2.0-beta.18 (published 2026-10-22/23), and the patch for beta.15 no longer applies.Fix
Pin
node-ptyto exactly1.2.0-beta.15inapps/server/package.jsonand update the lockfile specifier. The other patched runtime deps of the stage (@ff-labs/fff-node,dbus-next) are already exact. Upstream fixed the same drift in pingdotgg/t3code#23798; we take the full version of that with the upstream sync.Verification
pnpm install --frozen-lockfile --lockfile-onlypasses.node-pty: 1.2.0-beta.15plus the patch, no lockfile) installs beta.15 and applies the patch without errors.🤖 Generated with Claude Code