Merged
Conversation
|
Can one of the admins verify this patch? |
paigerube14
force-pushed
the
gcp_nodes
branch
from
ebdc0d2 to
3809046
Compare
This was referenced Nov 10, 2020
Closed
mffiedler
requested changes
Nov 13, 2020
paigerube14
force-pushed
the
gcp_nodes
branch
from
912af02 to
06040bb
Compare
mffiedler
reviewed
Nov 13, 2020
paigerube14
force-pushed
the
gcp_nodes
branch
2 times, most recently
from
0ed8395 to
62b6c85
Compare
paigerube14
force-pushed
the
gcp_nodes
branch
from
a68620a to
72fe662
Compare
mffiedler
approved these changes
Nov 17, 2020
Collaborator
mffiedler
left a comment
mffiedler
left a comment
There was a problem hiding this comment.
/LGTM - tested all supported scenarios on GCP and all worked well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add the node chaos scenarios for GCP clusters