fix: consolidate clippy & rust config on top of main, all the rest ca…

…uses duplication
kristof-mattei · Sep 1, 2023 · e158e41 · e158e41
1 parent 8ab8311
commit e158e41
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 15 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -364,7 +364,7 @@ jobs:
       - name: Run Clippy for GitHub Actions report
         uses: actions-rs-plus/clippy-check@9035ac35de400d5b7d37b4ce176ebd153e424d29 # v2
         with:
-          args: --workspace --all-targets --all-features -- --deny clippy::all --deny clippy::pedantic --deny clippy::cargo
+          args: --workspace --all-targets --all-features
 
   docker-build:
     name: Build Docker container

diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -34,18 +34,7 @@
         {
             "type": "cargo",
             "command": "clippy",
-            "args": [
-                "--workspace",
-                "--all-targets",
-                "--all-features",
-                "--",
-                "--deny",
-                "clippy::all",
-                "--deny",
-                "clippy::pedantic",
-                "--deny",
-                "clippy::cargo"
-            ],
+            "args": ["--workspace", "--all-targets", "--all-features"],
             "problemMatcher": ["$rustc"],
             "group": "build",
             "label": "Rust: cargo clippy"

diff --git a/clippy.toml b/clippy.toml
diff --git a/src/main.rs b/src/main.rs
@@ -1,8 +1,10 @@
-#![cfg_attr(not(debug_assertions), deny(warnings))]
 #![deny(clippy::all)]
 #![deny(clippy::pedantic)]
 #![deny(clippy::cargo)]
-#![forbid(non_ascii_idents)]
+#![deny(warnings)]
+// exceptions
+#![deny(let_underscore_drop)]
+#![deny(non_ascii_idents)]
 #![allow(clippy::uninlined_format_args)]
 
 // use std::path::PathBuf;