[JENKINS-72067] High memory usage from `XStream2.AssociatedConverterI…

…mpl` (jenkinsci#8529)
krisstern · Sep 29, 2023 · 91527dc · 91527dc
1 parent 6be55c1
commit 91527dc
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/core/src/main/java/hudson/util/XStream2.java b/core/src/main/java/hudson/util/XStream2.java
@@ -475,12 +475,8 @@ protected Class<? extends ConverterMatcher> computeValue(Class<?> type) {
                 return computeConverterClass(type);
             }
         };
-        private final ClassValue<Converter> cache = new ClassValue<Converter>() {
-            @Override
-            protected Converter computeValue(Class<?> type) {
-                return computeConverter(type);
-            }
-        };
+        private final ConcurrentHashMap<Class<?>, Converter> cache =
+                new ConcurrentHashMap<>();
 
         private AssociatedConverterImpl(XStream xstream) {
             this.xstream = xstream;
@@ -491,7 +487,9 @@ private Converter findConverter(@CheckForNull Class<?> t) {
             if (t == null) {
                 return null;
             }
-            return cache.get(t);
+            Converter result = cache.computeIfAbsent(t, unused -> computeConverter(t));
+            // ConcurrentHashMap does not allow null, so use this object to represent null
+            return result == this ? null : result;
         }
 
         @CheckForNull
@@ -515,7 +513,8 @@ private static Class<? extends ConverterMatcher> computeConverterClass(@NonNull
         private Converter computeConverter(@NonNull Class<?> t) {
             Class<? extends ConverterMatcher> cl = classCache.get(t);
             if (cl == null) {
-                return null;
+                // See above.. this object in cache represents null
+                return this;
             }
             try {
                 Constructor<?> c = cl.getConstructors()[0];