Fix issue trekhleb#98.

krishnahingu · Jul 13, 2018 · 863dbdb · 863dbdb
1 parent fafa52c
commit 863dbdb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/data-structures/tree/binary-search-tree/BinarySearchTreeNode.js b/src/data-structures/tree/binary-search-tree/BinarySearchTreeNode.js
@@ -132,6 +132,9 @@ export default class BinarySearchTreeNode extends BinaryTreeNode {
       }
     }
 
+    // Clear the parent of removed node.
+    nodeToRemove.parent = null;
+
     return true;
   }
 

diff --git a/src/data-structures/tree/binary-search-tree/__test__/BinarySearchTreeNode.test.js b/src/data-structures/tree/binary-search-tree/__test__/BinarySearchTreeNode.test.js
@@ -243,4 +243,13 @@ describe('BinarySearchTreeNode', () => {
 
     expect(bstNode.findMin().value).toEqual(obj1);
   });
+
+  it('should abandon removed node', () => {
+    const rootNode = new BinarySearchTreeNode('foo');
+    rootNode.insert('bar');
+    const childNode = rootNode.find('bar');
+    rootNode.remove('bar');
+
+    expect(childNode.parent).toBeNull();
+  });
 });
-Original file line number
+Diff line change
@@ Expand Up @@
           }
         }
+        // Clear the parent of removed node.
+        nodeToRemove.parent = null;
         return true;
       }
@@ Expand Down @@