Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed examples. #175

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Fixed examples. #175

merged 1 commit into from
Jun 14, 2017

Conversation

mrdoob
Copy link
Contributor

@mrdoob mrdoob commented Jun 14, 2017

Couldn't fix the wasm demo though.

#170

@mrdoob
Copy link
Contributor Author

mrdoob commented Jun 14, 2017

Seems like Atom did some space clean up.

This link should remove the noise:
https://github.com/kripken/ammo.js/pull/175/files?w=1

@kripken kripken merged commit 94a3e97 into kripken:master Jun 14, 2017
@kripken
Copy link
Owner

kripken commented Jun 14, 2017

Thanks!

@mrdoob
Copy link
Contributor Author

mrdoob commented Jun 14, 2017

You may want to delete the gh_pages branch and change the setting of the repo so the GitHub Page is built out of master.

@mrdoob
Copy link
Contributor Author

mrdoob commented Jun 14, 2017

I can see you're currently copy-pasting the builds inside the webgl_demo though.

@kripken
Copy link
Owner

kripken commented Jun 14, 2017

Yeah, good point. Done.

Sadly we still need to copy paste the wasm file for the wasm demo, no good way to load it from another directory yet.

@mrdoob
Copy link
Contributor Author

mrdoob commented Jun 15, 2017

no good way to load it from another directory yet

Out of curiosity... Do you know if there are any plans on fixing that? workers/wasm side?

@kripken
Copy link
Owner

kripken commented Jun 15, 2017

One option might be to embed the file, to work around this, emscripten-core/emscripten#5296 (but code size won't be great). Other options discussed here: emscripten-core/emscripten#5104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants