Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generateUrls compatible with UniversalRouterSync #172

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

frenzzy
Copy link
Member

@frenzzy frenzzy commented Sep 16, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixes #171

@codecov-io
Copy link

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #172   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         181    180    -1     
  Branches       53     53           
=====================================
- Hits          181    180    -1
Impacted Files Coverage Δ
src/generateUrls.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabd27d...457ea0a. Read the comment docs.

@frenzzy frenzzy merged commit e341346 into kriasoft:master Sep 16, 2019
@frenzzy frenzzy deleted the generate-urls-sync branch September 16, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generateUrls() does not work with universal-router/sync
2 participants