Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector search improvements #206

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Connector search improvements #206

merged 2 commits into from
Sep 6, 2023

Conversation

kreneskyp
Copy link
Owner

Description

Some usability improvements for the component search bar (NodeTypeSearch):

  • Search results are now cleared when the search input is cleared
  • Selecting a connector (once again) clears the search input

image

Changes

  • usePaginatedAPI now includes a clearPage callback to clear the returned state.
  • Search results are now cleared when the search input is cleared
  • Selecting a connector (once again) clears the search input

How Tested

Manual testing

TODOs

[List any outstanding TODOs or known issues that still need to be addressed.]

- search results (page) now cleared when search bar is emptied
- selecting a connector once again clears the query search string
- input state now synced to query so setting it also updates the input
@kreneskyp kreneskyp merged commit d7ccb20 into master Sep 6, 2023
5 checks passed
@kreneskyp kreneskyp deleted the connector_search_fix branch September 6, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant