Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastapi cleanup #160

Merged
merged 6 commits into from
Aug 12, 2023
Merged

Fastapi cleanup #160

merged 6 commits into from
Aug 12, 2023

Conversation

kreneskyp
Copy link
Owner

Description

This is the final-ish PR in the GraphQL -> FastAPI conversion. This PR converts the last couple bits that were still in use and deprecates graphql code and queries.

There are only a few remaining items using graphql:

  • subscriptions / websockets: These will remain for now. GraphQL websockets work very cleanly so not replacing them just yet.
  • Tasks: These views aren't in use so they weren't converted yet. May be done at a future point.

Changes

  • new chat button and redirect now use FastAPI
  • moved chat/graphql to chat/hooks

How Tested

[Explain how you tested this pull request. Include any relevant steps or scripts.]

TODOs

[List any outstanding TODOs or known issues that still need to be addressed.]

@kreneskyp kreneskyp merged commit bb569b7 into master Aug 12, 2023
5 checks passed
@kreneskyp kreneskyp deleted the fastapi_cleanup branch August 12, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant