Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate pydantic types for chain editor #122

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Conversation

kreneskyp
Copy link
Owner

Description

The config loader introduced some pydantic types for chain config. This PR merges them into types created for the FastAPI. This resolves a few ambiguities, and covers type checking for connectors and fields.

Changes

  • Merged config types into api types
  • cleaned up any non compliant objects

How Tested

  • existing unittests

TODOs

[List any outstanding TODOs or known issues that still need to be addressed.]

@kreneskyp kreneskyp merged commit 3cdfc32 into master Jul 16, 2023
@kreneskyp kreneskyp deleted the disambiguate_types branch July 16, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant