Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal values must be saved in product Price. #1954

Closed
ashishkumar-webkul opened this issue Jan 16, 2025 · 4 comments
Closed

Decimal values must be saved in product Price. #1954

ashishkumar-webkul opened this issue Jan 16, 2025 · 4 comments

Comments

@ashishkumar-webkul
Copy link
Collaborator

Bug report

Issue Description

When I am creating a product and then saving the price with Decimal Value, there we can see that the issue is appearing. Validation message for numerical value is appearing.

Preconditions

Admin must be logged in.

Steps to reproduce

  1. Go to Admin -> Products -> Create a new Product.
  2. Add price in decimal format.
  3. Check the validation warning message.

Expected result

Price should be accepted in decimal entries in product.

Actual result

Please check the Screenshot for reference -> https://prnt.sc/Y6nCL45iF8v7

@shivendra-webkul
Copy link
Collaborator

shivendra-webkul commented Jan 16, 2025

@ashishkumar-webkul I checked this issue but I was not able to reproduce it.

https://webkul.chatwhizz.com/share/view-recording/6788befdf2e9336a27cf2b2b

This is not an issue, please check the price attribute validation.

https://prnt.sc/jXzXKk8me_FT

@ashishkumar-webkul
Copy link
Collaborator Author

@shivendra-webkul

This issue is appearing for attribute type price. When you will select price and there you will be able to face the same issue.

@shivendra-webkul
Copy link
Collaborator

@ashishkumar-webkul

I have verified the type price attribute validation, and it is working properly. Please review and confirm.

Custom Type Price Attribute

  1. Created a type price attribute and assigned it to the product.
  2. Entered a decimal value and saved it successfully.
  3. Validation is functioning as expected.

Default Attributes

  1. Confirmed that the price attribute for default attributes is of type text, as specified in the data provided by the seeder.

Everything seems to be functioning correctly. Let me know if any further verification is required.

@ashishkumar-webkul
Copy link
Collaborator Author

Checked and found that the issue has been fixed. Price is working for positive entries and decimal entries.
-ve entries are restricted. Hence the issue is fixed.

Video

Price.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants