Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Button in Filters Not Visible in Dark Theme #1806

Closed
ashishkumar-webkul opened this issue Dec 11, 2024 · 1 comment
Closed

Update Button in Filters Not Visible in Dark Theme #1806

ashishkumar-webkul opened this issue Dec 11, 2024 · 1 comment

Comments

@ashishkumar-webkul
Copy link
Collaborator

Bug Report

Title

Update Button in Filters Not Visible in Dark Theme

Issue Description

When using the Dark Theme, the Update button in the Filters section is not visible, making it difficult for users to update or apply filters.

Steps to Reproduce

  1. Switch the application theme to Dark Mode.
  2. Navigate to any section with a filter (e.g., Leads, Contacts).
  3. Open the filter panel and attempt to locate the Update button.

Actual Result

  • The Update button is either not visible or poorly contrasted against the dark background.

Expected Result

  • The Update button should be clearly visible and easily identifiable, with proper contrast and alignment.

Proposed Solution

  1. Adjust the button's color and styling in Dark Theme to ensure it stands out against the background.
  2. Use accessible color contrast ratios for text and button borders.
  3. Test the UI for consistent visibility across different themes.

Acceptance Criteria

  1. The Update button is clearly visible and functional in Dark Theme.
  2. The button styling adheres to the application's design guidelines for Dark Theme.
  3. Proper testing ensures the fix works across all sections with filters.

Attachments:

https://prnt.sc/M4hCeX3I25KR

Video

Dark.theme.Update.button.mp4
@ashishkumar-webkul
Copy link
Collaborator Author

Checked and found that the issue has been fixed.

https://prnt.sc/yexyZOdPuTqi
https://prnt.sc/ygDucPh9CSyx

devansh-webkul added a commit that referenced this issue Jan 13, 2025
Fixed issue #1806 (Update Button in Filters Not Visible in Dark Theme and Empty image Cross icon )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants