Show tooltips previewing URLs in ArtistLinks menu #227
Conversation
herrhotzenplotz
changed the title
herrhotzenplotz
force-pushed
the
feat/external-artist-urls
branch
from
d2c2fc3
to
10cf50c
Compare
herrhotzenplotz
changed the title
|
Ok after I looked at this again I found out that I was comparing two different artists before and after my changes. The second was showing more links than the first so I assumed that it worked. However, it turns out that the Spotify API seems to never actually return any useful value in the list of external URLs, so my changes (except for the tooltips) were a no-op. In any case, I still believe the tooltips are a useful feature. |
Just a minor feature that I was missing when I was digging around in Spotify. This enables tooltips on the artist menu such that you can preview the URL you're about to open in your web browser. Signed-off-by: Nico Sonack <[email protected]>
herrhotzenplotz
force-pushed
the
feat/external-artist-urls
branch
from
10cf50c
to
7aa3c2f
Compare
There was a problem hiding this comment.
Feels like either all links should have tooltips, or none, but I guess these links can be less obvious where they go, so it might be a good idea to show. Looks good! 😄
Also let me know if you don't have commit signing set up, and I'll temporarily disable it to merge this. It's mostly as a reminder for myself to not forget. You can just ignore the failed FreeBSD action. It does that sometimes, but for some reason it doesn't let me restart it from a pull request.
I haven't bothered configuring commit signing with hg-git. Maybe I should if it is possible?
I've done the testing on FreeBSD already 😄 and tbh this is a bit a fail on Github's side as they don't have true runners for FreeBSD. |
|
In this case I don't think it makes a huge difference, as I believe GitHub adds its own "Verified" status for code merged from within GitHub itself anyway. I'll merge this as is, and you can configure GPG signing later if you want 😄 |
Just one of those little features that I was missing when I was digging around in Spotify :-)
Also, this enables tooltips on the artist menu such that you can preview the URL you're about to open in your web browser.
EDIT: somehow I was confusing something here. Lemme go dig into this a bit tomorrow.