Skip to content

Update uhtml dependencies and logic #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krausest merged 1 commit into from
Jul 3, 2021
Merged

Update uhtml dependencies and logic #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 60 additions & 60 deletions frameworks/keyed/uhtml/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 5 additions & 8 deletions frameworks/keyed/uhtml/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@
"description": "uhtml demo",
"main": "index.js",
"js-framework-benchmark": {
"frameworkVersionFromPackage": "uhtml",
"issues": [
801
]
"frameworkVersionFromPackage": "uhtml"
},
"scripts": {
"build-dev": "rollup -c -w",
Expand All @@ -27,13 +24,13 @@
},
"homepage": "https://github.com/krausest/js-framework-benchmark#readme",
"dependencies": {
"js-framework-benchmark-utils": "^0.2.5",
"uhtml": "^2.7.5"
"js-framework-benchmark-utils": "^0.3.2",
"uhtml": "^2.7.6"
},
"devDependencies": {
"@rollup/plugin-node-resolve": "^13.0.0",
"@ungap/degap": "^0.2.6",
"rollup": "^2.52.1",
"@ungap/degap": "^0.2.7",
"rollup": "^2.52.6",
"rollup-plugin-includepaths": "^0.2.4",
"rollup-plugin-minify-html-literals": "^1.2.6",
"rollup-plugin-terser": "^7.0.2"
Expand Down
4 changes: 2 additions & 2 deletions frameworks/keyed/uhtml/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import {State} from 'js-framework-benchmark-utils';
import {html, render} from 'uhtml';

import Jumbotron from './jumbotron.js';
import Table from './table-delegate.js';
import Table from './table.js';

const state = State(Table);
const state = State(Table, false, html.for);

render(document.getElementById('container'), html`
<div class="container">
Expand Down
24 changes: 24 additions & 0 deletions frameworks/keyed/uhtml/src/table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import {html} from 'uhtml';

export default (state) => {
const {data, selected, selectRow, removeRow} = state;
return html.for(state)`
<table class="table table-hover table-striped test-data" .state=${state}>
<tbody>${
data.map(({id, label, html}) => html`
<tr id=${id} class=${id === selected ? 'danger' : ''}>
<td class="col-md-1">${id}</td>
<td class="col-md-4">
<a @click=${selectRow}>${label}</a>
</td>
<td class="col-md-1">
<a @click=${removeRow}>
<span class="glyphicon glyphicon-remove" aria-hidden="true" />
</a>
</td>
<td class="col-md-6" />
</tr>`
)}</tbody>
</table>
`;
};