Skip to content

Conversation

@leeoniya
Copy link
Contributor

@leeoniya leeoniya commented Jul 3, 2017

hey @krausest,

this is both a lib & implementation update which takes advantage of a new lazyList feature in v3 that reuses vnodes from the old vtree when a cheap diff indicates no changes.

it may be a bit faster overall, but the major win here is a ~20% mem reduction.

thanks!

@leeoniya leeoniya changed the title domvm-v3.0.0 domvm-v3.0.1 Jul 3, 2017
@krausest krausest merged commit abb4e2f into krausest:master Jul 4, 2017
@krausest
Copy link
Owner

krausest commented Jul 4, 2017

Merged! Results are here.
Any idea why travis couldn't checkout domvm in the pull request correctly? Let's see if it works on master...

@leeoniya
Copy link
Contributor Author

leeoniya commented Jul 4, 2017

thanks!

i removed the console timers (and the forced-sync redraws which were only there to facilitate them) since i no longer use them and they bloat the impl. this change leaves the impl with domvm's native async api which has the improved clear rows effect already observed here [1]. i just want to note this here because it's not a micro-optimization since that's just how the lib has always worked and if anyone's lib works this way out of the box, then that's perfectly fine, too. the main purpose of the update was to reduce mem use, which definitely stood out among libs in the same perf range :)

i dunno what Travis is up to; he sounds like a real hooligan.

[1] #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants