Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Svelte 1.20.2, keyed and non-keyed #181

Merged
merged 1 commit into from
May 17, 2017
Merged

add Svelte 1.20.2, keyed and non-keyed #181

merged 1 commit into from
May 17, 2017

Conversation

Rich-Harris
Copy link
Contributor

We have a completely new approach to keyed updates now, so it's a good time to update the Svelte implementation. Thanks!

@Rich-Harris Rich-Harris mentioned this pull request May 17, 2017
Closed
@krausest krausest merged commit 3f8ae86 into krausest:master May 17, 2017
@krausest
Copy link
Owner

Thanks. Isn't it funny that commit #666 is for a non-framework framework?
Results are here
Looks pretty good except for swap rows in the keyed implementation. Seems like all rows are updated.

@Rich-Harris Rich-Harris deleted the svelte-1.20.2 branch May 17, 2017 18:36
@Rich-Harris
Copy link
Contributor Author

Thanks! I've opened an issue so that we can look into that — sveltejs/svelte#588.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @krausest