feat(CSP): Added optional custom impl function that creates a report-uri #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstuart
force-pushed
the
master
branch
2 times, most recently
from
1425157 to
6043229
Compare
|
Looks good to me. |
| @@ -71,6 +71,7 @@ If enabled, the CSRF token must be in the payload when modifying data or you wil | |||
| * `options.policy` Object - Object definition of policy. | |||
| * `options.reportOnly` Boolean - Enable report only mode. | |||
| * `options.reportUri` String - URI where to send the report data | |||
| * `options.impl` Function - Optional. Custom implementation to create a report-uri. | |||
There was a problem hiding this comment.
I think it would be better to note in the documentation that the impl will have high precedence over the reportUri
|
Thx for the feedback @thefourtheye |
| @@ -71,6 +71,7 @@ If enabled, the CSRF token must be in the payload when modifying data or you wil | |||
| * `options.policy` Object - Object definition of policy. | |||
| * `options.reportOnly` Boolean - Enable report only mode. | |||
| * `options.reportUri` String - URI where to send the report data | |||
| * `options.impl` Function - Custom implementation to create a report-uri (higher priority than `options.reportUri`) | |||
There was a problem hiding this comment.
Now it is missing the optional part.
|
This looks good. Any blocker? |
|
@turboMaCk does this satisfy your needs as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implfunction that creates a report-uri. Used if you want to tack on a token or some unique identifier to the end of the report-uri to help identify a user or session (for logging, analytics, etc.)/cc @jasisk