-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update eslint #17
Conversation
@nbierdeman i think 5.2.0 should work for the typescript parser, but can you confirm please and thank you? <3 |
1763968
to
a08b8fd
Compare
@@ -69,9 +70,8 @@ | |||
"@babel/preset-react": "^7", | |||
"@babel/register": "^7.10.5", | |||
"@babel/runtime": "7.12.13", | |||
"@typescript-eslint/eslint-plugin": "^5.0.0", | |||
"@typescript-eslint/parser": "^4.31.2", | |||
"babel-eslint": "10.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed. move to @babel/eslint-parser
- update to use the @babel/eslint-parser to resolve imports properly from the import plugin - update all packages to recent versions - set `requireConfigFile` to false for @babel/eslint-parser to be able to scan older packages in `node_modules`
a08b8fd
to
24e88be
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westeezy, I'm also getting that eslint-find-rules
error locally:
|
lets set |
from the import plugin
requireConfigFile
to false for @babel/eslint-parser to be ableto scan older packages in
node_modules