Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eslint #17

Merged
merged 6 commits into from
Nov 10, 2021
Merged

chore: update eslint #17

merged 6 commits into from
Nov 10, 2021

Conversation

westeezy
Copy link
Contributor

@westeezy westeezy commented Nov 1, 2021

  • update to use the @babel/eslint-parser to resolve imports properly
    from the import plugin
  • update all packages to recent versions
  • set requireConfigFile to false for @babel/eslint-parser to be able
    to scan older packages in node_modules

@westeezy westeezy requested a review from a team as a code owner November 1, 2021 15:50
@westeezy
Copy link
Contributor Author

westeezy commented Nov 1, 2021

@nbierdeman i think 5.2.0 should work for the typescript parser, but can you confirm please and thank you? <3

@@ -69,9 +70,8 @@
"@babel/preset-react": "^7",
"@babel/register": "^7.10.5",
"@babel/runtime": "7.12.13",
"@typescript-eslint/eslint-plugin": "^5.0.0",
"@typescript-eslint/parser": "^4.31.2",
"babel-eslint": "10.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed. move to @babel/eslint-parser

- update to use the @babel/eslint-parser to resolve imports properly
  from the import plugin
- update all packages to recent versions
- set `requireConfigFile` to false for @babel/eslint-parser to be able
  to scan older packages in `node_modules`
@westeezy
Copy link
Contributor Author

westeezy commented Nov 1, 2021

find-eslint-rules has an active PR for updating to eslint v8 here sarbbottam/eslint-find-rules#336. This is why we have a CI failure so let's await those updates.

@westeezy westeezy marked this pull request as draft November 1, 2021 20:09
Copy link
Contributor

@nbierdeman nbierdeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westeezy, I'm also getting that eslint-find-rules error locally:

Screen Shot 2021-11-01 at 1 57 17 PM

@westeezy
Copy link
Contributor Author

westeezy commented Nov 9, 2021

eslint-find-rules release v4 today which works with eslint v8. This also is exposing a lot more unused rules than previous so I'll take a peek and see if its false positive or accurate. Kinda stinks that we paste in like all the rules rather than just the ones we change from default :(

@westeezy
Copy link
Contributor Author

westeezy commented Nov 9, 2021

lets set find-eslint-rules to not error for now. I've never been a big fan of that tool when you have lots of eslint plugins. We can update that later as time permits.

@westeezy westeezy marked this pull request as ready for review November 9, 2021 17:47
@westeezy westeezy changed the base branch from master to v4 November 10, 2021 18:41
@westeezy westeezy merged commit 7498db0 into krakenjs:v4 Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants