Skip to content

Commit

Permalink
[media] media: atmel-isi: increase the burst length to improve the pe…
Browse files Browse the repository at this point in the history
…rformance

The burst length could be BEATS_4/8/16. Before this patch, isi use default
value BEATS_4. To imporve the performance we could set it to BEATS_16.

Otherwise sometime it would cause the ISI overflow error.

Reported-by: Bo Shen <[email protected]>
Signed-off-by: Josh Wu <[email protected]>
Signed-off-by: Guennadi Liakhovetski <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
JoshWu committed Jun 25, 2015
1 parent 86cd52f commit a189298
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/media/platform/soc_camera/atmel-isi.c
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,8 @@ static int isi_camera_set_bus_param(struct soc_camera_device *icd)
if (isi->pdata.full_mode)
cfg1 |= ISI_CFG1_FULL_MODE;

cfg1 |= ISI_CFG1_THMASK_BEATS_16;

isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS);
isi_writel(isi, ISI_CFG1, cfg1);

Expand Down
4 changes: 4 additions & 0 deletions include/media/atmel-isi.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@
#define ISI_CFG1_FRATE_DIV_MASK (7 << 8)
#define ISI_CFG1_DISCR (1 << 11)
#define ISI_CFG1_FULL_MODE (1 << 12)
/* Definition for THMASK(ISI_V2) */
#define ISI_CFG1_THMASK_BEATS_4 (0 << 13)
#define ISI_CFG1_THMASK_BEATS_8 (1 << 13)
#define ISI_CFG1_THMASK_BEATS_16 (2 << 13)

/* Bitfields in CFG2 */
#define ISI_CFG2_GRAYSCALE (1 << 13)
Expand Down

0 comments on commit a189298

Please sign in to comment.