feat(tree): Add the array representation of the binary tree(js,ts) #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
krahets
reviewed
Aug 10, 2023
codes/javascript/modules/TreeNode.js
Outdated
| if (node) { | ||
| if (++i >= arr.length) break; | ||
| if (arr[i] !== null) node.left = new TreeNode(arr[i]); | ||
| if (++i >= arr.length) break; |
There was a problem hiding this comment.
Please match this function to other languages'(Java, C++, Python) implementation. We'd like to make the code consistent in terms of all the languages.
There was a problem hiding this comment.
Done, I've tested to make sure it's ok, please check
justin-tse
reviewed
Aug 12, 2023
krahets
approved these changes
Aug 13, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.