Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure rust code, using library way, not include #1528

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

rongyi
Copy link
Contributor

@rongyi rongyi commented Oct 11, 2024

I hurts me everytime when I see include in rust, time to fix this.

@krahets krahets added code Code-related polish Decorative detail or feature labels Oct 23, 2024
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates! Thank you!

@krahets krahets merged commit ef3010b into krahets:main Oct 23, 2024
3 of 4 checks passed
@krahets
Copy link
Owner

krahets commented Oct 23, 2024

Hi @rongyi, I’d like to invite you to be a code reviewer for our project. We’ll also thank you on the landing page for your contribution. Please let me know if you’re interested in joining.

@rongyi
Copy link
Contributor Author

rongyi commented Oct 24, 2024

@krahets I’m honored to be a reviewer for your remarkable project. I look forward to contributing valuable insights and feedback to help ensure its success.

@krahets
Copy link
Owner

krahets commented Oct 25, 2024

@rongyi Please add my WeChat krahets-jyd if you're convenient. I'll invite you to the reviewers' group chat.

And please check your profile on the landing page:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code-related polish Decorative detail or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants