Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(JavaScript): Add the workflow file for CI check #1296

Merged
merged 5 commits into from
Apr 22, 2024
Merged

feat(JavaScript): Add the workflow file for CI check #1296

merged 5 commits into from
Apr 22, 2024

Conversation

Shyam-Chen
Copy link
Contributor

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

  • This PR represents the translation of a single, complete document, or contains only bug fixes.
  • The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist:

  • I have thoroughly reviewed the code, focusing on its formatting, comments, indentation, and file headers.
  • I have confirmed that the code execution outputs are consistent with those produced by the reference code (Python or Java).
  • The code is designed to be compatible on standard operating systems, including Windows, macOS, and Ubuntu.

Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please address the comment

- uses: actions/setup-node@v4
with:
node-version: 20.x
- uses: denoland/setup-deno@v1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need deno for JS?

Copy link
Contributor Author

@Shyam-Chen Shyam-Chen Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, test_all.js is executed through Deno. In Node, glob is not built-in, whereas it is available in Deno (import { expandGlob } from '@std/fs';), making it easier to use Deno for writing code that requires glob functionality.

Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@krahets krahets merged commit 1a99dd4 into krahets:main Apr 22, 2024
4 checks passed
@krahets krahets added enhancement Brand new feature code Code-related labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code-related enhancement Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants