feat: Add Ruby code - chapter "Searching" #1262
Conversation
There was a problem hiding this comment.
Hi @bluebean-cloud, thanks for the PR, I have some comments
| =end | ||
|
|
||
| ### 二分查找插入点（存在重复元素） ### | ||
| def binary_search_insertion(nums, target) |
There was a problem hiding this comment.
Please import this method from the binary_search_insertion.rb file
require_relative './binary_search_insertion'There was a problem hiding this comment.
Thank you for reviewing!
If I use require_relative, then the driver Code in binary_search_insertion.rb may be like:
### Driver Code ###
if __FILE__ == $0
# Code
end
Otherwise the driver code in binary_search_insertion.rb will be executed when executing binary_serch_edge.rb.
So may I make this change? @khoaxuantu
There was a problem hiding this comment.
Yes, it is. Actually, at the very first I did not expect the case that we will import another method from an index file. I will create another PR to put all the existing driver code at branch main into the __FILE__ == 0 block.
There was a problem hiding this comment.
OK. I will put my driver code into the __FILE__==0 block.
Thanks for suggestion!
There was a problem hiding this comment.
369f7e3 has fixed all bugs. thank you for the review!
| ### 方法一：暴力枚举 ### | ||
| def two_sum_brute_force(nums, target) | ||
| # 两层循环，时间复杂度为 O(n^2) | ||
| for i in 0...nums.length |
There was a problem hiding this comment.
In the python code, the for loop is
for i in range(len(nums) - 1):It traverse the nums in range [0, nums.length - 1).
In your code, the loop traverses in range [0, nums.length). So please change to this to have a correct range:
suggestion~~ ~~for i in 0..nums.length~~ ~~
There was a problem hiding this comment.
0..nums.lenth seems to traverse the nums in [0, nums.length]. I will repair it, thank you!
There was a problem hiding this comment.
Oops! I got a mistake in the suggestion code. It should be
| for i in 0...nums.length | |
| for i in 0...(nums.length - 1) |
Sorry for the misinformation 😃
There was a problem hiding this comment.
I have made all the changes in commit
369f7e3
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: