Fix build failure when PublicizerLogFilePath is a bare filename - #198
Merged
Conversation
Path.GetDirectoryName of a bare filename returns an empty string, and Directory.CreateDirectory then throws ArgumentException. The catch logged it via LogError, failing the build instead of writing the log beside the project. Skip directory creation when there is no directory portion.
krafs
changed the title
krafs
marked this pull request as ready for review
July 22, 2026 17:57
This was referenced Jul 26, 2026
This was referenced Aug 3, 2026
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A relative
PublicizerLogFilePathwith no directory portion (e.g.publicizer.log) failed the build:Path.GetDirectoryNamereturns"",Directory.CreateDirectory("")throws, and the catch reports it viaLogError, which fails compilation. The directory is now created only when the path has one.Regression test: a project with a bare log filename builds successfully and writes the log.