Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations for kr8s._async_utils #417

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

jacobtomlinson
Copy link
Member

More fixes towards #381.

After this there are 44 mypy errors.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.33%. Comparing base (87063fc) to head (a50dc2c).
Report is 119 commits behind head on main.

Files with missing lines Patch % Lines
kr8s/_async_utils.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   94.61%   95.33%   +0.71%     
==========================================
  Files          29       30       +1     
  Lines        3141     3645     +504     
==========================================
+ Hits         2972     3475     +503     
- Misses        169      170       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 0182ca6 into kr8s-org:main Jun 28, 2024
10 checks passed
@jacobtomlinson jacobtomlinson deleted the mypy-async-utils branch June 28, 2024 13:57
@jacobtomlinson jacobtomlinson changed the title Add type annotations for kr8s._async_utils Add type annotations for kr8s._async_utils Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant