Bump dependencies in kpt and porch #3035
Conversation
| k8s.io/api v0.24.0-rc.0 | ||
| k8s.io/apimachinery v0.24.0-rc.0 | ||
| k8s.io/apiserver v0.24.0-rc.0 | ||
| k8s.io/client-go v0.24.0-rc.0 | ||
| k8s.io/component-base v0.24.0-rc.0 |
There was a problem hiding this comment.
what drives the change to take dependency on RC build?
There was a problem hiding this comment.
Not an expert on k8s lib release versions. But the RC release contains the right version which will resolve the dependency conflicts that blocks bumping builtin functions in Porch, and blocks bumping kyaml in kpt.
The former is needed for the next fishfooding and the RC seems the most stable version we can use. @mengqiy correct me if I'm wrong.
More context is here: https://github.com/kubernetes/client-go/issues/1075
There was a problem hiding this comment.
We want to include a kyaml change (kubernetes-sigs/kustomize#4568) which contains a performance improvement for both kpt and porch. This change requires kubernetes/kube-openapi#283 which is merged after breaking change kubernetes/kube-openapi#285.
The kube-openapi breaking change was imported to k8s after v0.24.0 (kubernetes/kubernetes#108644). It means that NO 0.23.X k8s packages (including apimachinery and client-go) work with our desired kyaml change.
According to k8s 1.24 release schedule, 0.24.0-rc.1 is expected on 04/26 and 0.24.0 is expected on 05/03.
| if !meta.MaybeResetRESTMapper(mapper) { | ||
| return fmt.Errorf("failed to reset RESTMapper: %T", mapper) | ||
| } | ||
| meta.MaybeResetRESTMapper(mapper) |
There was a problem hiding this comment.
so this doesn't throw any errors anymore ?
There was a problem hiding this comment.
It doesn't throw error any more.
|
SWEEEET!!! |
4 participants
The 1st commit vendor some packages from cli-utils to the
thirdpartydirectory.The 2nd commit update the dependencies for kpt and porch.