BREAK: remove 2.7 support; remove docker; use travis python #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aikikode
force-pushed
the
feature/drop_27_support
branch
2 times, most recently
from
b9603ec
to
0274982
Compare
kammala
reviewed
Nov 26, 2020
aikikode
force-pushed
the
feature/drop_27_support
branch
from
0274982
to
02ee75f
Compare
kammala
reviewed
Nov 26, 2020
aikikode
force-pushed
the
feature/drop_27_support
branch
5 times, most recently
from
fbe659a
to
112dc53
Compare
kammala
previously approved these changes
Nov 26, 2020
aikikode
force-pushed
the
feature/drop_27_support
branch
6 times, most recently
from
06a10cb
to
3bc0740
Compare
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 95 86 -9
Branches 13 11 -2
=========================================
- Hits 95 86 -9
Continue to review full report at Codecov.
|
aikikode
force-pushed
the
feature/drop_27_support
branch
from
3bc0740
to
d18384e
Compare
kammala
previously approved these changes
Nov 30, 2020
setup.py
Outdated
| @@ -26,8 +26,6 @@ | |||
| "Intended Audience :: Developers", | |||
| "Operating System :: OS Independent", | |||
| "Programming Language :: Python", | |||
| "Programming Language :: Python :: 2", | |||
| "Programming Language :: Python :: 2.7", | |||
| "Programming Language :: Python :: 3", | |||
| "Programming Language :: Python :: 3.5", | |||
There was a problem hiding this comment.
shall we drop this one as well?
requirements.txt
Outdated
| @@ -11,9 +12,10 @@ wheel | |||
| mypy; python_version >= '3.5' | |||
There was a problem hiding this comment.
python version specifier might be dropped as well
aikikode
force-pushed
the
feature/drop_27_support
branch
from
d18384e
to
46fd371
Compare
aikikode
force-pushed
the
feature/drop_27_support
branch
from
46fd371
to
a6a4645
Compare
kammala
approved these changes
Dec 1, 2020
ricardosantosalves
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.