Support up to 9.8 #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because there is the potential for lots of them in Cabal.hs
Closed
This reverts commit 728d658dd9267461b5f5b3ea542774af828c21a4.
This requires * Bumping some dependencies * Pinning Cabal to ^>= 3.10, because the set of exposed extensions increases with every cabal release so the 'extensions' library is not buildable with older Cabals, without missing some cases in the pattern match in Cabal.hs. * Adding support for multiple new extensions
Collaborator
Author
|
Actually, only up to 9.6, because |
ulidtko
reviewed
Jun 15, 2025
Comment on lines
+85
to
+95
| build-depends: bytestring >= 0.10 && < 0.13 | ||
| -- We need to pin a single major version of | ||
| -- Cabal here because the main reason we use | ||
| -- Cabal is for its list of extensions. Later | ||
| -- versions have strictly more extensions, and | ||
| -- we'll have missing patterns if we try to | ||
| -- support more than one major version. If | ||
| -- this causes problems in practice let's | ||
| -- revisit this decision and come up with | ||
| -- another approach. | ||
| , Cabal ^>= 3.10 |
There was a problem hiding this comment.
Spinned off a discussion in #111.
This hit me when trying to package extensions @ the latest for ArchLinux which is still on GHC 9.4.8 (unfortunately). I had to pin the package to 0.1.0.0.
Collaborator
Author
There was a problem hiding this comment.
Thanks, is there anything I need to do to support you, or is this just for information, like #111?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.