shell.nix: add dependency needed on Apple silicon#4399
Merged
kovidgoyal merged 1 commit intokovidgoyal:masterfrom Dec 30, 2021
Merged
shell.nix: add dependency needed on Apple silicon#4399kovidgoyal merged 1 commit intokovidgoyal:masterfrom
kovidgoyal merged 1 commit intokovidgoyal:masterfrom
Conversation
shell.nix is missing a depencency on the UserNotifications framework on macOS with Apple silicon. Unfortunately we can't just unconditionally include this dependency because Nixpkgs uses a different macOS SDK version for macOS on an Intel processor compared to macOS on Apple silicon. The older SDK version 10.12 on Intel does not have the UserNotifications framework, which would lead to an "attribute missing" error when trying to execute `nix-shell`. The condition can be dropped when the macOS SDK version for Intel processors is finally updated. See NixOS/nixpkgs#101229 for progress on that. See NixOS/nixpkgs#137512 for more context. Closes kovidgoyal#4352.
|
Can confirm it builds on a M1Max Macbook 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shell.nix is missing a depencency on the UserNotifications framework on macOS with Apple silicon. Unfortunately we can't just unconditionally include this dependency because Nixpkgs uses a different macOS SDK version for macOS on an Intel processor compared to macOS on Apple silicon. The older SDK version 10.12 on Intel does not have the UserNotifications framework, which would lead to an "attribute missing" error when trying to execute
nix-shell. The condition can be dropped when the macOS SDK version for Intel processors is finally updated. See NixOS/nixpkgs#101229 for progress on that.See NixOS/nixpkgs#137512 for more context.
Closes #4352.
@kovidgoyal Please don't merge this until someone with an M1 Mac has actually tested this.
@alexghr could you please test this and confirm that it fixes the problem? I don't have an M1 Mac to test with myself.