Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logo): make the icon more inline with Big Sur #3548

Merged
merged 1 commit into from
Apr 28, 2021
Merged

fix(logo): make the icon more inline with Big Sur #3548

merged 1 commit into from
Apr 28, 2021

Conversation

MindTooth
Copy link
Contributor

This tries to follow the Human Interface Guidelines from Apple.

Screenshots

Icon-256

Screen Shot 2021-04-28 at 15 19 18

Environment

  • macOS 11.3
  • kitty 0.20.2

Possible fixes

Fixes #3547.

This tries to follow the Human Interface Guidelines
from Apple.
@MindTooth MindTooth marked this pull request as draft April 28, 2021 13:45
@MindTooth
Copy link
Contributor Author

MindTooth commented Apr 28, 2021

Noticed that this was an old version. Missing the shadows.

It should work. Unfortunately, I messed up my Figma, losing the current version.

@MindTooth MindTooth marked this pull request as ready for review April 28, 2021 13:49
@kovidgoyal kovidgoyal merged commit c8c22d3 into kovidgoyal:master Apr 28, 2021
@MindTooth
Copy link
Contributor Author

I need to apply an attribute given the CC BY 4.0 license. Something that I thought of after I submitted this.

The most ideal place to add? A small note in the readme, or its own file in the logo folder?

@kovidgoyal
Copy link
Owner

A file in the logo folder would be best I believe.

@benatshippabo
Copy link

Thanks for doing this @MindTooth ❤️

@d4vsanchez
Copy link

This is awesome! Current version (0.20.2) icon looks really disproportionate with other icons. Do you know when this change is going to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[minor] New macOS icon is bigger than it should be
5 participants