Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exporterbim.js force color to integer #430

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

ricaun
Copy link
Contributor

@ricaun ricaun commented Oct 24, 2023

Force RGB to round to be an integer.

Depending on the material color, the viewer export dotbim file with color in double format.

The color need to be integer.

Force to round color to integer
`ColorComponentFromFloat` has parceInt.
@kovacsv kovacsv added this to the Online3DViewer 0.12.0 milestone Oct 24, 2023
@kovacsv kovacsv changed the base branch from master to dev October 24, 2023 16:06
@kovacsv kovacsv merged commit 97333a9 into kovacsv:dev Oct 24, 2023
7 checks passed
@kovacsv
Copy link
Owner

kovacsv commented Oct 24, 2023

Nice catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants