Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update connect_scrypted_client #932

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Update connect_scrypted_client #932

merged 1 commit into from
Jul 6, 2023

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Jul 5, 2023

  1. Allows session to be passed in
  2. transport is passed in so we can disconnect
  3. Outdented most of the logic that doesn't need to be within the context manager
  4. Added DeviceManager to SDK for completeness

@koush koush merged commit c31e68f into koush:main Jul 6, 2023
@raman325 raman325 deleted the connect branch July 6, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raman325 @koush