Reolink only-token client added #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koush
reviewed
Oct 19, 2024
koush
reviewed
Oct 19, 2024
koush
reviewed
Oct 19, 2024
plugins/reolink/src/reolink-api.ts
Outdated
| @@ -89,8 +89,12 @@ export class ReolinkCameraClient { | |||
| await this.login(); | |||
| const url = options.url as URL; | |||
| const params = url.searchParams; | |||
| for (const [k, v] of Object.entries(this.parameters)) { | |||
| params.set(k, v); | |||
| if(this.forceToken) { | |||
There was a problem hiding this comment.
this change is not necessary. the purpose of parameters it to return parameters needed for auth. why manually parsing them out?
There was a problem hiding this comment.
done, some calls fail if providing both token and user/pass, but if forceToken is set they will never be set
There was a problem hiding this comment.
How would both token and username pass be set?
There was a problem hiding this comment.
in this case it's not possible, it was something from the previous branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.