Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

レビュー訴求をできるようにする - 訴求するかのロジック追加 #332

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

kosenda
Copy link
Owner

@kosenda kosenda commented Nov 11, 2023

Issue

Overview

  • UseCase2つ追加した
  • 次のPRで、レビュー用のダイアログでOKボタン(案)を押すと以降はレビューを表示しない仕組みを入れてレビュー訴求は一旦完成する予定
  • 色々と一気に追加してPRが大きくなってしまって、この説明を書くのも個人開発だしな〜ってなってしまって面倒になったから書かない

@KSNDBOT
Copy link
Collaborator

KSNDBOT commented Nov 11, 2023

1 Warning
⚠️ No coverage data found for ksnd/hiraganaconverter/core/domain/repository/ReviewInfoRepository

JaCoCo Code Coverage 74.77% ✅

Class Covered Meta Status
ksnd/hiraganaconverter/core/data/repository/ReviewInfoRepositoryImpl 50% 0%
ksnd/hiraganaconverter/viewmodel/MainActivityViewModel 33% 0%
ksnd/hiraganaconverter/core/domain/usecase/ConvertTextUseCase 100% 0%
ksnd/hiraganaconverter/core/domain/usecase/CompletedRequestReviewUseCase 100% 0%
ksnd/hiraganaconverter/core/domain/usecase/ObserveNeedRequestReviewUseCase 100% 0%
ksnd/hiraganaconverter/core/domain/repository/ReviewInfoRepository No coverage data found : -% No coverage data found : -% 🃏

Generated by 🚫 Danger

@kosenda kosenda merged commit 2b8bf40 into main Nov 11, 2023
@kosenda kosenda deleted the feature/add-request-review-logic branch November 11, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants