Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

レビュー訴求をできるようにする - 最終レビュー訴求日を文字列でなくLocalDateとして保存 #331

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

kosenda
Copy link
Owner

@kosenda kosenda commented Nov 9, 2023

Issue

Overview

  • kotlinx-datetimeを使用してLocalDateを保存するようにした
  • テストもちょっと追加した
  • 他にjava.util.LocalDateを使用しているところがたくさんあるが、kotlinx-datetimeに移行しようと思う

@kosenda kosenda changed the title レビュー訴求をできるようにする - 最終レビュー訴求日をLocalDateとして保存 レビュー訴求をできるようにする - 最終レビュー訴求日を文字列でなくLocalDateとして保存 Nov 9, 2023
@KSNDBOT
Copy link
Collaborator

KSNDBOT commented Nov 9, 2023

1 Warning
⚠️ No coverage data found for ksnd/hiraganaconverter/core/domain/repository/ReviewInfoRepository

JaCoCo Code Coverage 73.79% ✅

Class Covered Meta Status
ksnd/hiraganaconverter/core/data/repository/ReviewInfoRepositoryImpl 50% 0%
ksnd/hiraganaconverter/core/domain/repository/ReviewInfoRepository No coverage data found : -% No coverage data found : -% 🃏

Generated by 🚫 Danger

@kosenda kosenda merged commit e721161 into main Nov 9, 2023
@kosenda kosenda deleted the refactor/change-localdate-in-proto-datastore branch November 9, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants