Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

レビュー訴求をできるようにする - レビューを表示するためのデータ用のRepository作成 #330

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

kosenda
Copy link
Owner

@kosenda kosenda commented Nov 8, 2023

Issue

Overview

  • 前回のPRで作成した累計変換回数を新しく作ったReviewInfoRepositoryに移した
  • Proto DataStoreを使用するようにして、1つのクラスでReview用のデータを管理するようにした

chore: 消し忘れ削除
@kosenda kosenda force-pushed the feature/make-review-info-repository branch from a43fab2 to eecf971 Compare November 8, 2023 17:07
@KSNDBOT
Copy link
Collaborator

KSNDBOT commented Nov 8, 2023

2 Warnings
⚠️ No coverage data found for ksnd/hiraganaconverter/core/domain/repository/ReviewInfoRepository
⚠️ No coverage data found for ksnd/hiraganaconverter/core/domain/repository/DataStoreRepository

JaCoCo Code Coverage 73.68% ✅

Class Covered Meta Status
ksnd/hiraganaconverter/core/data/repository/ReviewInfoRepositoryImpl 50% 0%
ksnd/hiraganaconverter/core/data/repository/DataStoreRepositoryImpl 83% 0%
ksnd/hiraganaconverter/core/domain/usecase/ConvertTextUseCase 100% 0%
ksnd/hiraganaconverter/core/domain/repository/ReviewInfoRepository No coverage data found : -% No coverage data found : -% 🃏
ksnd/hiraganaconverter/core/domain/repository/DataStoreRepository No coverage data found : -% No coverage data found : -% 🃏

Generated by 🚫 Danger

@kosenda kosenda merged commit 0be840d into main Nov 8, 2023
@kosenda kosenda deleted the feature/make-review-info-repository branch November 8, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants