Analyticsをある程度対応させる１ #299
Merged
Analyticsをある程度対応させる１ #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosenda
commented
Oct 29, 2023
| @@ -119,28 +125,30 @@ class MainActivity : AppCompatActivity() { | |||
| } | |||
| } | |||
|
|
|||
| HiraganaConverterTheme( | |||
kosenda
commented
Oct 29, 2023
| /** | ||
| * Analytics for Mock (no-op) | ||
| */ | ||
| class MockAnalytics : Analytics { |
There was a problem hiding this comment.
NIAではNoOp〜だったけど個人的にわかりにくいからMockとした
kosenda
commented
Oct 29, 2023
| @@ -53,6 +53,7 @@ accompanist-webView = { group = "com.google.accompanist", name = "accompanist-we | |||
| androidx-activity = { group = "androidx.activity", name = "activity", version.ref = "activity" } | |||
| androidx-appcompat = { group = "androidx.appcompat", name = "appcompat", version.ref = "androidxAppCompat" } | |||
| androidx-compose-material3 = { group = "androidx.compose.material3", name = "material3", version.ref = "androidxComposeMaterial3" } | |||
| androidx-compose-runtime = { group = "androidx.compose.runtime", name = "runtime", version.ref = "androidxUi" } | |||
There was a problem hiding this comment.
staticCompositionLocalOfを使うために入れた
|
ScreenShotTestで失敗している... |
kosenda
commented
Oct 29, 2023
| @@ -30,8 +27,9 @@ import org.robolectric.annotation.GraphicsMode | |||
| @GraphicsMode(GraphicsMode.Mode.NATIVE) | |||
| @Config(qualifiers = RobolectricDeviceQualifiers.Pixel6Pro) | |||
| class ConverterScreenTest { | |||
| @get:Rule | |||
| val composeTestRule = createAndroidComposeRule<MainActivity>() | |||
| // FIXME: I have commented out the error since I started to Inject Firebase into MainActivity. | |||
KSNDBOT
reviewed
Oct 29, 2023
app/src/test/java/ksnd/hiraganaconverter/view/screen/ConverterScreenTest.kt
Outdated
Show resolved
Hide resolved
JaCoCo Code Coverage 74.59% ✅
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
Reference
LOG