Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【リファクタ】命名がおかしい-1 #255

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Conversation

kosenda
Copy link
Owner

@kosenda kosenda commented Oct 7, 2023

Issue

Overview

  • DataStoreからFlowで受け取っているメソッドがselectedThemeとかselectedFontTypeになっていたからthemeとかfontTypeに変更した(NIAを参考にした)
  • DBからFlowで受け取っているメソッドがgetAllConvertHistoryになっていたからobserveAllConvertHistoryに変更した

@KSNDBOT
Copy link
Collaborator

KSNDBOT commented Oct 7, 2023

3 Warnings
⚠️ No coverage data found for ksnd/hiraganaconverter/data/database/ConvertHistoryDao
⚠️ No coverage data found for ksnd/hiraganaconverter/core/domain/repository/DataStoreRepository
⚠️ No coverage data found for ksnd/hiraganaconverter/core/domain/repository/ConvertHistoryRepository

JaCoCo Code Coverage 69.93% ✅

Class Covered Meta Status
ksnd/hiraganaconverter/feature/setting/SettingsViewModel 100% 0%
ksnd/hiraganaconverter/viewmodel/MainActivityViewModel 16% 0%
ksnd/hiraganaconverter/feature/history/ConvertHistoryViewModel 91% 0%
ksnd/hiraganaconverter/data/database/ConvertHistoryDao No coverage data found : -% No coverage data found : -% 🃏
ksnd/hiraganaconverter/data/repository/ConvertHistoryRepositoryImpl 100% 0%
ksnd/hiraganaconverter/data/repository/DataStoreRepositoryImpl 83% 0%
ksnd/hiraganaconverter/core/domain/repository/DataStoreRepository No coverage data found : -% No coverage data found : -% 🃏
ksnd/hiraganaconverter/core/domain/repository/ConvertHistoryRepository No coverage data found : -% No coverage data found : -% 🃏

Generated by 🚫 Danger

@kosenda kosenda merged commit 4796d25 into main Oct 7, 2023
@kosenda kosenda deleted the refacotor/change-name branch October 7, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants