Skip to content

変換履歴はFlowで取得する #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2023
Merged

変換履歴はFlowで取得する #173

merged 1 commit into from
Aug 13, 2023

Conversation

kosenda
Copy link
Owner

@kosenda kosenda commented Aug 13, 2023

Issue

fix #172

Overview

  • 変更履歴はFlowで取得するようにした
  • Mockデータを作成した
  • テストがうまくいかなくて消してしまうものが多くなってしまった

@KSNDBOT
Copy link
Collaborator

KSNDBOT commented Aug 13, 2023

2 Warnings
⚠️ No coverage data found for ksnd/hiraganaconverter/model/repository/ConvertHistoryRepository
⚠️ No coverage data found for ksnd/hiraganaconverter/model/ConvertHistoryDao

JaCoCo Code Coverage 68.08% ✅

Class Covered Meta Status
ksnd/hiraganaconverter/viewmodel/ConvertHistoryViewModel 100% 0% ✅
ksnd/hiraganaconverter/viewmodel/ConvertHistoryViewModelImpl 91% 0% ✅
ksnd/hiraganaconverter/model/repository/ConvertHistoryRepositoryImpl 100% 0% ✅
ksnd/hiraganaconverter/model/repository/ConvertHistoryRepository No coverage data found : -% No coverage data found : -% 🃏
ksnd/hiraganaconverter/MockConvertHistories 100% 0% ✅
ksnd/hiraganaconverter/model/ConvertHistoryDao No coverage data found : -% No coverage data found : -% 🃏

Generated by 🚫 Danger

@kosenda kosenda merged commit bf8d03a into main Aug 13, 2023
@kosenda kosenda deleted the refactor/history-record-to-flow branch August 13, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

変換履歴はFlowで取得する
2 participants
@kosenda @KSNDBOT