Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【リファクタ】SettingsViewModelImplでmutableStateOfをStateFlowにする #159

Merged
merged 2 commits into from
Aug 6, 2023
Merged

【リファクタ】SettingsViewModelImplでmutableStateOfをStateFlowにする #159

merged 2 commits into from
Aug 6, 2023

Conversation

kosenda
Copy link
Owner

@kosenda kosenda commented Aug 6, 2023 •
edited
Loading

Issue

fix #158

Overview

  • SettingsViewModelImplでmutableStateOfをStateFlowにした
  • themeとかfontTypeを渡すときにクラスでなくStringとかIntとか渡していて危ないためクラスを指定した

@KSNDBOT
Copy link
Collaborator

KSNDBOT commented Aug 6, 2023

1 Warning
⚠️ No coverage data found for ksnd/hiraganaconverter/model/repository/DataStoreRepository

JaCoCo Code Coverage 76.89% ✅

Class Covered Meta Status
ksnd/hiraganaconverter/viewmodel/MainViewModel 100% 0% ✅
ksnd/hiraganaconverter/viewmodel/SettingsViewModel 100% 0% ✅
ksnd/hiraganaconverter/viewmodel/SettingsViewModelImpl 100% 0% ✅
ksnd/hiraganaconverter/model/repository/DataStoreRepositoryImpl 100% 0% ✅
ksnd/hiraganaconverter/model/repository/DataStoreRepository No coverage data found : -% No coverage data found : -% 🃏

Generated by 🚫 Danger

@kosenda kosenda merged commit 10dc341 into main Aug 6, 2023
@kosenda kosenda deleted the refactor/mutablestate-to-mutablestateflow branch August 6, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【リファクタ】SettingsViewModelImplでmutableStateOfをStateFlowにする
2 participants
@kosenda @KSNDBOT