ViewModelにcontext渡さない #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Code Coverage 0.58% ✅
Generated by 🚫 Danger |
KSNDBOT
reviewed
Jul 22, 2023
| convertHistoryDataList.value.removeIf { it.id == id } | ||
| } | ||
| } | ||
| //class ConvertHistoryRepositoryImplTest { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // convertHistoryRepositoryImpl.deleteConvertHistory(id = histories[1].id) | ||
| // assertThat(convertHistoryRepositoryImpl.getAllConvertHistory().size).isEqualTo(2) | ||
| // } | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // } | ||
| //} | ||
| // | ||
| //private class FakeConvertHistoryDao : ConvertHistoryDao { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // override fun deleteConvertHistory(id: Long) { | ||
| // convertHistoryDataList.value.removeIf { it.id == id } | ||
| // } | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| } | ||
| } | ||
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| } | ||
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) | ||
| //@RunWith(RobolectricTestRunner::class) |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) | ||
| //@RunWith(RobolectricTestRunner::class) | ||
| //class DataStoreRepositoryImplTest { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // } | ||
| // } | ||
| // } | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| testData.removeIf { deleteTarget -> deleteTarget.id == id } | ||
| } | ||
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| } | ||
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) | ||
| //class ConvertHistoryViewModelImplTest { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // } | ||
| // | ||
| // // ■ 変換履歴の詳細ダイアログに関するテスト ------------------------------------------------- End | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // // ■ 変換履歴の詳細ダイアログに関するテスト ------------------------------------------------- End | ||
| //} | ||
| // | ||
| //private class FakeConvertHistoryRepository(exitsInitData: Boolean) : ConvertHistoryRepository { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // override fun deleteConvertHistory(id: Long) { | ||
| // testData.removeIf { deleteTarget -> deleteTarget.id == id } | ||
| // } | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| override suspend fun updateCustomFont(newCustomFont: CustomFont) {} | ||
| override suspend fun checkReachedConvertMaxLimit(today: String) = isReachedConvertMaxLimit | ||
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| override suspend fun checkReachedConvertMaxLimit(today: String) = isReachedConvertMaxLimit | ||
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) | ||
| //@RunWith(RobolectricTestRunner::class) |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) | ||
| //@RunWith(RobolectricTestRunner::class) | ||
| //class ConvertViewModelImplTest { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // assertThat(viewModel.uiState.value.outputText).isNotEqualTo("") | ||
| // } | ||
| // } | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // } | ||
| //} | ||
| // | ||
| //private fun createTestingConvertViewModel( |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // testDispatcher: CoroutineDispatcher, | ||
| // isErrorResponse: Boolean, | ||
| // isReachedConvertMaxLimit: Boolean, | ||
| //): ConvertViewModelImpl { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // ioDispatcher = testDispatcher, | ||
| // defaultDispatcher = testDispatcher, | ||
| // ) | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // ) | ||
| //} | ||
| // | ||
| //@OptIn(ExperimentalSerializationApi::class) |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| //} | ||
| // | ||
| //@OptIn(ExperimentalSerializationApi::class) | ||
| //private class FakeConverterRepository( |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| //private class FakeConverterRepository( | ||
| // context: Context, | ||
| // isErrorResponse: Boolean, | ||
| //) : ConvertRepository { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // val body = json.toRequestBody(contentType) | ||
| // return runBlocking { convertService.requestConvert(body) } | ||
| // } | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // } | ||
| //} | ||
| // | ||
| //private class FakeInterceptor( |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| //private class FakeInterceptor( | ||
| // private val isErrorResponse: Boolean, | ||
| // private val context: Context, | ||
| //) : Interceptor { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // .request(request) | ||
| // .build() | ||
| // } | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // } | ||
| //} | ||
| // | ||
| //private class FakeConvertHistoryRepositoryImpl : ConvertHistoryRepository { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // override fun getAllConvertHistory(): List<ConvertHistoryData> = emptyList() | ||
| // override fun deleteAllConvertHistory() {} | ||
| // override fun deleteConvertHistory(id: Long) {} | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // override fun deleteConvertHistory(id: Long) {} | ||
| //} | ||
| // | ||
| //private class FakeDataStoreRepositoryImpl( |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // | ||
| //private class FakeDataStoreRepositoryImpl( | ||
| // private val isReachedConvertMaxLimit: Boolean, | ||
| //) : DataStoreRepository { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // override suspend fun updateThemeNum(newThemeNum: Int) {} | ||
| // override suspend fun updateCustomFont(newCustomFont: CustomFont) {} | ||
| // override suspend fun checkReachedConvertMaxLimit(today: String) = isReachedConvertMaxLimit | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| assertThat(viewModel.isSelectedFont(CustomFont.DEFAULT)).isFalse() | ||
| } | ||
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| } | ||
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) | ||
| //@RunWith(RobolectricTestRunner::class) |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| } | ||
| //@OptIn(ExperimentalCoroutinesApi::class) | ||
| //@RunWith(RobolectricTestRunner::class) | ||
| //class SettingsViewModelImplTest { |
There was a problem hiding this comment.
| Missing space after // |
KSNDBOT
reviewed
Jul 22, 2023
| // assertThat(viewModel.isSelectedFont(CustomFont.BIZ_UDGOTHIC)).isTrue() | ||
| // assertThat(viewModel.isSelectedFont(CustomFont.DEFAULT)).isFalse() | ||
| // } | ||
| //} |
There was a problem hiding this comment.
| Missing space after // |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#97
Overview
ErrorInterceptorにもApplicationContextを渡してしまっていたのでConvertViewModelのメソッドconvertと併せてcontextを渡さないようにしたConvertErrorType、カスタムException3種類(ConvertTextUseCaseError.kt)）を経由するようにした